[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd00557e3f4: [clang][parser] Allow GNU attributes before namespace identifier (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/ne

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. In D121245#3382887 , @ArcsinX wrote: > In D121245#3380346 , @aaron.ballman > wrote: > >> LGTM! Might be worth adding a release note for it (doe

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX added a comment. In D121245#3380346 , @aaron.ballman wrote: > LGTM! Might be worth adding a release note for it (does this close any bugs > in the bug database? If so, it'd be worth mentioning those in the commit > message and release note). T

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 415470. ArcsinX added a comment. Update release notes Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/new/ https://reviews.llvm.org/D121245 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/Pa

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Might be worth adding a release note for it (does this close any bugs in the bug database? If so, it'd be worth mentioning those in the commit message and release note).

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:79 + + auto ReadLabelAttrubutes = [&] { +// Read label attributes, if present. aaron.ballman wrote: > However, I don't think there's a reaso

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX updated this revision to Diff 414868. ArcsinX added a comment. - get attributes location from ParsedAttributesWithRange object - parse subsequent attributes of different kinds in a loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121245/ne

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman added a comment. Oh wow, GCC has supported this for a long time; I wasn't aware of that. Thanks for this patch! Comment at: clang/lib/Parse/ParseDeclCXX.cpp:79 + + auto ReadLabelAttrubutes = [&] { +// Read label attributes, if present. Howev

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, rsmith. Herald added a subscriber: jdoerfert. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC supports: - `namespace identifie