[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've committed in 1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https:

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman updated this revision to Diff 413793. aaron.ballman added a comment. Added a comment and an additional test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https://reviews.llvm.org/D121211 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseAST.cpp

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is already an evaluation context created in Sema but it's never popped back. And because we rely heavily on there always being at least one evaluation context (`ExprEvalContexts.back

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, bruno, rsmith. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We were not creating an evaluation context for the TU scope, so we never popped an