zaks.anna added a comment.
Thanks for the fix! We'll commit shortly.
Repository:
rL LLVM
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a comment.
Thank you for reviewing!
Repository:
rL LLVM
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248050: Analyzer: Fix a crasher in UbigraphViz (authored by
ismailp).
Changed prior to commit:
http://reviews.llvm.org/D12119?vs=35141&id=35142#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12119
ismailp updated this revision to Diff 35141.
ismailp added a comment.
- Added a new test file instead of adding '-analyzer-viz-egraph-ubigraph' to an
existing test.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
test/Analysis/ubigraph-viz.cpp
Index:
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Otherwise, LGTM.
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
zaks.anna added a comment.
I see, Maybe we should add a new test file to test this instead of adding it to
an existing test.
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
ismailp added a comment.
I don't have ubigraph installed either. The purpose of the test isn't to check
as to whether we can generate a conforming/sensible ubigraph output, but to
ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But
if you are worried about other/unkn
zaks.anna added inline comments.
Comment at: test/Analysis/free.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -
ismailp added a comment.
Thank you for the feedback! I have added the test in a C file, so we can get
the first part of the patch in -- between lines 778-780.
I think self-loop is a different problem, and that requires its own patch. I'll
see what I can do about self-loop, if someone else isn't
ismailp updated this revision to Diff 34082.
ismailp added a comment.
- Rolled back to the first version of patch, where only parameter `Out` is
renamed to `OutStream`
- Use a different test that doesn't trigger the self-loop assertion.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyze
zaks.anna added a comment.
I do not understand why there should be a cycle here in the Exploded Graph.
Most likely this assertion uncovers a bug in cfg-temporary-doors, which is a
disabled by default feature (it has not been completed yet). You can think of
"ProgramState" as the state of the pr
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 @@
-
- assert (Src != Dst && "Self-edges are not allowed.");
-
krememek wrote:
> Did you look at the test case that causes this assertion to fail? I think i
ismailp updated this revision to Diff 32903.
ismailp added a comment.
- Change parameter name to `OutStream`.
http://reviews.llvm.org/D12119
Files:
lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp
test/Analysis/cfg.cpp
Index: test/Analysis/cfg.cpp
==
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 @@
-
- assert (Src != Dst && "Self-edges are not allowed.");
-
Did you look at the test case that causes this assertion to fail? I think it
would be good
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:778
@@ -780,3 +777,3 @@
-UbigraphViz::UbigraphViz(std::unique_ptr Out, StringRef Filename)
-: Out(std::move(Out)), Filename(Filename), Cntr(0) {
+UbigraphViz::UbigraphViz(std::unique
ismailp updated this revision to Diff 32745.
ismailp added a comment.
- Renamed `Out` parameter to `Stm`.
- Removed assertion that checks whether an ExplodedNode has an edge to itself.
- Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test.
http://reviews.llvm.org/D12119
Fi
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
assert (Src != Dst && "Self-edges are not allowed.");
ismailp wrote:
> Is Ubigraph generator actively maintained? If I run tests with
> '-a
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:784
@@ -783,3 +783,3 @@
- *Out << "('vertex_style_attribute', 0, ('shape', 'icosahedron'))\n";
- *Out << "('vertex_style', 1, 0, ('shape', 'sphere'), ('color', '#ffcc66'),"
+ *this->O
ismailp added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
assert (Src != Dst && "Self-edges are not allowed.");
Is Ubigraph generator actively maintained? If I run tests with
'-analyzer-viz-egraph-u
ismailp created this revision.
ismailp added reviewers: zaks.anna, krememek.
ismailp added a subscriber: cfe-commits.
Name `Out` refers to the parameter. It is moved into the member `Out`
in ctor-init. Dereferencing null pointer will crash clang, if user
passes '-analyzer-viz-egraph-ubigraph' argu
21 matches
Mail list logo
