Re: [PATCH] D12110: [SemaExpr] Re-enable missing assertion

2015-08-18 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. LGTM http://reviews.llvm.org/D12110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12110: [SemaExpr] Re-enable missing assertion

2015-08-18 Thread Davide Italiano via cfe-commits
While at it, maybe the assertion can be modernized removing the != 0 part. On Tue, Aug 18, 2015 at 3:09 PM, Davide Italiano wrote: > davide created this revision. > davide added a reviewer: rsmith. > davide added a subscriber: cfe-commits. > > This has been disabled for a long time, but: > 1) Ini

[PATCH] D12110: [SemaExpr] Re-enable missing assertion

2015-08-18 Thread Davide Italiano via cfe-commits
davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. This has been disabled for a long time, but: 1) Initializers work (and apparently they're re reason why this was disabled). 2) various tests happen to hit this code path and the invariant seems t