[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks for breaking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham added a comment. I like this version! This definitely says to me "nobody is going to just thoughtlessly append to an existing file". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 _

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 added a comment. > Yeah that sounds good. Maybe aarch64-cortex-cpus.c might be a good start, to > avoid having too many small files. Oops, I went ahead and split to many small cortex test files. Not really sure what would be better. What do you think @simon_tatham @fhahn @tmatheson ?

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 marked 2 inline comments as done. tyb0807 added inline comments. Comment at: clang/test/Driver/aarch64-archs.c:296 -// NO-LS64-NOT: "-target-feature" "+ls64" -// LS64: "-target-feature" "+ls64" - tmatheson wrote: > Looks like these were duplicate tests? B

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tmatheson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks! Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files. ---

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham accepted this revision. simon_tatham added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // ti

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. Thanks for picking this up, LGTM Comment at: clang/test/Driver/aarch64-archs.c:296 -// NO-LS64-NOT: "-target-feature" "+ls64" -// LS64: "-target-feature" "+ls64" -

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 marked an inline comment as done. tyb0807 added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // ti

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

simon_tatham added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:2 +// Check target CPUs are correctly passed. +// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test // times for large single test files.

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

tyb0807 created this revision. tyb0807 added reviewers: dmgreen, lenary, tmatheson, simon_tatham, fhahn. Herald added a subscriber: kristof.beyls. Herald added a project: All. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is