[PATCH] D121092: [pseudo] Strip comments for TokenStream.

2022-03-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01ac18df93: [pseudo] Strip comments for TokenStream. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

2022-03-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 413446. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121092/new/ https://reviews.llvm.org/D121092 Files: clang/include/clang/

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

2022-03-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:144 +/// Drops comment tokens. +TokenStream stripComments(const TokenStream &); sammccall wrote: > I think this fits more naturally into Token.h next to cook(). >

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

2022-03-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Preprocess.h:144 +/// Drops comment tokens. +TokenStream stripComments(const TokenStream &); ---

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

2022-03-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. Add a utility function to strip comments from a "raw" tokenstream. The derived stream wil