[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-04-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay closed this revision. MaskRay added a comment. a749e3295df4aee18a0ad723875a6501f30ac744 pushed by Aaron does not have a `Differential Revision:` line. Manual closing. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-04-23 Thread Tanya Lattner via Phabricator via cfe-commits
tonic added a comment. In D121078#3402469 , @aaron.ballman wrote: > In D121078#3400810 , @SimplyDanny > wrote: > >> @tonic, can you please have another look? > > If @tonic has any additional feedback, we can han

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D121078#3400810 , @SimplyDanny wrote: > @tonic, can you please have another look? If @tonic has any additional feedback, we can handle it post-commit at this point. I've gone ahead and committed this on your behalf in

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-22 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny added a comment. @tonic, can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 ___ cfe-commits mailing list cfe-commits@

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-16 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. LGTM, thanks for fixing the documentation quirks in libc++/libunwind! And sorry this went under my Radar last week :-). @tonic Is this OK with you? I don't want to override your "request for changes" by committing this. Repository: rG

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-10 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny added a comment. In D121078#3373139 , @philnik wrote: > In D121078#3373081 , @SimplyDanny > wrote: > >> I'm happy that you found a reasonable compromise. I like it too. ;) >> >> Now, I ask you to help

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-10 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all tak

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are a

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-10 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny added a comment. I'm happy that you found a reasonable compromise. I like it too. ;) Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "n

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. In D121078#3368424 , @tonic wrote: > In D121078#3367950 , @aaron.ballman > wrote: > >> I've added comments to the few places I'd like to see a

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-08 Thread Tanya Lattner via Phabricator via cfe-commits
tonic added a comment. In D121078#3367950 , @aaron.ballman wrote: > In D121078#3367289 , @tonic wrote: > >> In D121078#3366825 , >> @aaron.ballman wrote: >> >>> In D1210

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D121078#3367289 , @tonic wrote: > In D121078#3366825 , @aaron.ballman > wrote: >

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-08 Thread Tanya Lattner via Phabricator via cfe-commits
tonic added a comment. In D121078#3366825 , @aaron.ballman wrote: > In D121078#3366025 , @tonic wrote: > >> In D121078#3365542 , @SimplyDanny >> wrote: >> >>> In D121078

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D121078#3366025 , @tonic wrote: > In D121078#3365542 , @SimplyDanny > wrote: > >> In D121078#3363856 , >> @aaron.ballman wrote: >> >>>

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Tanya Lattner via Phabricator via cfe-commits
tonic added a comment. In D121078#3365542 , @SimplyDanny wrote: > In D121078#3363856 , @aaron.ballman > wrote: > >> I think we need to retain *some* references to the existing mailing list >> archives. The migr

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny updated this revision to Diff 413642. SimplyDanny added a comment. Removed duplicate target names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 Files: clang-tools-extra/README.txt clang

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny added a comment. In D121078#3363856 , @aaron.ballman wrote: > I think we need to retain *some* references to the existing mailing list > archives. The migration to Discourse worked fairly well, but there were still > data migration issues.

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny added inline comments. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on the Clang development mailing list: - http://lists.llvm.org/mailman/listinfo/cfe-dev +in the Clang forum: + https://discourse.

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny updated this revision to Diff 413630. SimplyDanny marked 9 inline comments as done. SimplyDanny added a comment. Updated revision according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.ll

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Tanya Lattner via Phabricator via cfe-commits
tonic requested changes to this revision. tonic added a comment. Thank you so much for doing this! I have added some comments inline that I would like changed. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think we need to retain *some* references to the existing mailing list archives. The migration to Discourse worked fairly well, but there were still data migration issues. For example: https://discourse.llvm.org/t/memory-barrier-problem/57493 https://lists.llvm

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-07 Thread Louis Dionne via Phabricator via cfe-commits
ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Thanks for doing this! We need to fix a few undefined references, though. Comment at: libcxx/docs/index.rst:223 * `libcxx-commits Mailing List`_ * `libcxx-dev M

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-06 Thread Danny Mösch via Phabricator via cfe-commits
SimplyDanny created this revision. SimplyDanny added a reviewer: tonic. Herald added subscribers: libcxx-commits, arphaman. Herald added a reviewer: sscalpone. Herald added projects: libunwind, Flang, All. Herald added a reviewer: libunwind. SimplyDanny requested review of this revision. Herald add