[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

This revision was automatically updated to reflect the committed changes. Closed by commit rG036088fd6ea2: [MLIR][Python] Add SCFIfOp Python binding (authored by chhzh123, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12107

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Passed pre-merge checks. Should be able to be merged. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414900. chhzh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py mlir/test/python/dialec

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

mehdi_amini added a comment. Seems like there is a local base commit in your repository: you're not uploading a diff that applies on HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. I've rebased to the latest commit in the main branch, but the pre-merge checks still failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414852. chhzh123 added a comment. Try rebasing again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py mlir/test/p

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414847. chhzh123 added a comment. Rebase 3 commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py mlir/test/pyt

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 414845. chhzh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/test/python/dialects/scf.py Index: mlir/test/python/dialects

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

mehdi_amini added a comment. Can you rebase? Your patch does not apply apparently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing list c

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. @ftynse Thanks for reviewing! Could you help land the PR? Seems I do not have access rights to push to the main repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 _

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

ftynse accepted this revision. ftynse added a comment. Thanks! Let me know if you need help landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cf

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Hi @ftynse , could you please take a look at it and see if there is anything that should be changed? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 marked 2 inline comments as done. chhzh123 added a comment. @ftynse Sorry for messing up this PR a bit. I've made the changes you suggested. Please have a check. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://re

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413532. chhzh123 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py mlir/test/python/dialects/

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413528. chhzh123 added a comment. Fix function signature and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/test/python/dialects/scf.py In

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413520. chhzh123 added a comment. Revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 Files: mlir/python/mlir/dialects/_scf_ops_ext.py Index: mlir/python/mlir

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. Oh seems I made a wrong merge from the master branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing list cfe

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 updated this revision to Diff 413518. chhzh123 added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, libcxx-commits, pcwang-thead, awarzynski, arjunp, luke957, abrachet, Groverkss, ormris, foad, mravishankar, frasercrmck, dexonsmith, ecnelises, ThomasRaoux,