[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Thanks @steakhal ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG90a6e3547863: [analyzer][NFC] Merge similar conditional paths (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://r

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413402. phyBrackets added a comment. used the correct name for Opcodes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisIntro.m

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Shadowing potential names is not a good idea. BTW OpCodes are often abbreviated to `Op` in variable names in this context. Comment at: clang/lib/StaticAnalyzer/

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. Sorry but Idk why that DataFlowAnalysisIntro typo change also commited , I only add the deadstorechecker file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 ___

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets updated this revision to Diff 413300. phyBrackets added a comment. query the opcode only once and reuse it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 Files: clang/docs/DataFlowAnalysisI

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

phyBrackets added a comment. In D121045#3362373 , @steakhal wrote: > I would probably query the opcode only once and reuse it, but is also fine. > > Btw whats your intention making this change? Do you plan greater > refactorings/cleanups? Yeah, I think

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (though I'd also be fine if we only wanted to call `getOpcode()` once). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121045/new/ https://reviews.llvm.org/D121045 __

[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I would probably query the opcode only once and reuse it, but is also fine. Btw whats your intention making this change? Do you plan greater refactorings/cleanups? Repository: rG LLVM