[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

2022-03-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5eb365069cc: [CUDA][HIP] Fix offloading kind for linking C++ programs (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Gi

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

2022-03-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 412989. yaxunl added a comment. add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120911/new/ https://reviews.llvm.org/D120911 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Driver.cpp clang/test/Driver/hip-phases.hip

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

2022-03-03 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. We should probably also check what happens when we specify compilation language explicitly: E.g. `clang -x cuda a.cu -x c++ b.cc`, `clang -x cuda a.cu b.cc` and `clang a.cu -x cuda b.cc`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120911/new/ https://review

[PATCH] D120911: [CUDA][HIP] Fix offloading kind for linking C++ programs

2022-03-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. When both CUDA or HIP programs and C++ programs are passed to clang driver without `-c`, C++ programs are treated as CUDA or