[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ee97c24efab: [clang][dataflow] Add a lattice to track source locations. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56 +// Returns a string that represents the source locations of the lattice. +std::string DebugString(const SourceLocationsLattice &Lattic

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel updated this revision to Diff 412747. ymandel added a comment. added FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://reviews.llvm.org/D120890 Files: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattic

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

xazax.hun accepted this revision. xazax.hun added a comment. Herald added a subscriber: rnkovacs. In D120890#3357454 , @ymandel wrote: > In D120890#3357438 , @xazax.hun > wrote: > >> Is there anything special abo

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel added a comment. In D120890#3357438 , @xazax.hun wrote: > Is there anything special about `SourceLocation`s? I wonder whether we just > want a templated `PowerSet` lattice and instantiate it with `SourceLocation`s. Not really. Just that we use t

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

xazax.hun added a comment. Is there anything special about `SourceLocation`s? I wonder whether we just want a templated `Set` lattice and instantiate it with `SourceLocation`s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://revi

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel marked 5 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:56 +// Returns a string that represents the source locations of the lattice. +std::string DebugString(const SourceLocationsLat

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel updated this revision to Diff 412701. ymandel added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120890/new/ https://reviews.llvm.org/D120890 Files: clang/include/clang/Analysis/FlowSensitive/SourceLocationsL

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:26 + +// Lattice for dataflow analysis that keeps track of a set of source locations. +// Doc comments start with `///`. Comment at:

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/SourceLocationsLattice.h:13 + +#ifndef LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_SOURCELOCATIONS_LATTICE_H_ +#define LLVM_

[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

ymandel created this revision. ymandel added a reviewer: sgatev. Herald added subscribers: tschuett, steakhal, mgrang, mgorny. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds a simpe lattice used to collect source loctions. An