[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b969b0bb53e: [clang][parser] Stop dragging an EndLoc around when parsing attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo C

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 413276. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from two formatting nits, thank you for the cleanup! Comment at: clang/lib/Parse/ParsePragma.cpp:1373 - PragmaAttributeInfo(ParsedAttributes &Attr

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412994. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder marked an inline comment as done. tbaeder added a comment. In D120888#3359798 , @aaron.ballman wrote: > Thank you for working on this! We've (very) slowly been working towards all > of the attribute parsing functions taking a `ParsedAttributesWi

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

aaron.ballman added a comment. Thank you for working on this! We've (very) slowly been working towards all of the attribute parsing functions taking a `ParsedAttributesWithRange` so that we don't lose this information in the AST, and this is a good step in the right direction towards that. =

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412714. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that this is basically always unused. And if it is needed, the end of th