[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG942c03910aef: [Clang] Diagnose invalid member variable with template parameters (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (I'm a bit sad about the diagnostic differences, but I understand why they're different a bit better now, so this is fine.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1208

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin added a comment. In D120881#3357015 , @erichkeane wrote: > Do we have a test somewhere to check the variable template specialization > case to make sure that didn't break? Otherwise LGTM. Thanks for the review. It seems fairly well covered in

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Do we have a test somewhere to check the variable template specialization case to make sure that didn't break? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412689. cor3ntin added a comment. - Fix redundant check - move test to p17.cpp which seems more approriate - add a couple of tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

aaron.ballman added a comment. Thanks for looking into this, that's a rather amusing bug. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3398-3399 +if (isInstField && +D.getName().getKind() == UnqualifiedIdKind::IK_TemplateId) { + Diag(D.getIdentifierLoc(), diag:

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412654. cor3ntin added a comment. Fix Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm.org/D120881 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/54151 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/