This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG840695814ae3: [AMDGPU] Add gfx1036 target (authored by
Aakanksha ).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120846/new/
https://reviews.llvm.org/D120846
___
aakanksha555 updated this revision to Diff 412554.
aakanksha555 added a comment.
Rebase patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120846/new/
https://reviews.llvm.org/D120846
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cu
aakanksha555 updated this revision to Diff 412547.
aakanksha555 added a comment.
Herald added a subscriber: mgorny.
Update openmp/libomptarget/DeviceRTL/CMakeLists.txt as well.
clang/test/Driver/cuda-bad-arch.cu to be updated with all gfx10 targets in a
separate patch.
Repository:
rG LLVM Git
rampitec added a comment.
Looks like cuda-bad-arch.cu does not have any gfx10. Let's fix this in a
separate followup patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120846/new/
https://reviews.llvm.org/D120846
___
rampitec added a comment.
You also need to rebase it, I have just landed gfx940 target.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120846/new/
https://reviews.llvm.org/D120846
___
cfe-commits mailing
rampitec added a comment.
Please also update these 2 files:
clang/test/Driver/cuda-bad-arch.cu
openmp/libomptarget/DeviceRTL/CMakeLists.txt
In fact the last one was not updated before too, so the last target gfx1031
there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
aakanksha555 created this revision.
aakanksha555 added reviewers: rampitec, msearles, kzhuravl.
Herald added subscribers: asavonic, foad, dexonsmith, kerbowa, rupprecht,
hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm,
jholewinski.
Herald added a reviewer: jhenderson.