[PATCH] D120774: [clang-format] Handle builtins in constraint expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4d68bf65ef: [clang-format] Handle builtins in constraint expression (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D120774?vs=413430&id=414881#toc Repository: r

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: HazardyKnusperkeks wrote: > HazardyKnusperkeks wrote: > > owenpan wrote: > > > cjdb wrote: > > > > owenpan wrote: > > > > > Do we s

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > cjdb wrote: > > owenpan wrote: > > > Do we still n

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: cjdb wrote: > owenpan wrote: > > Do we still need this line? > I'd prefer to get rid of `default` if we can. We can't. It's the who

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

cjdb accepted this revision. cjdb added a comment. Thanks for working on this! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > Do we still need this line? I'd prefer to get rid of `default` i

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: Do we still need this line? Comment at: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3090-3093 +#define TYPE_TRAIT(N, I, K) case tok::kw_##I: +#define ARRAY_TYPE_TRAIT(I, E, K) case tok::kw_##I: +#define EXPRESSION_TRAIT(I, E, K) case tok::kw_##I: +#include "clang/Basic

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 413430. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.c

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3090-3093 +#define TYPE_TRAIT(N, I, K) case tok::kw_##I: +#define ARRAY_TYPE_TRAIT(I, E, K) case tok::kw_##I: +#define EXPRESSION_TRAIT(I, E, K) case tok::kw_##I: +#include "clang/Basic/TokenKinds

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks for handling other traits! LGTM % alias test. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integr

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + HazardyKnusperkeks wrot

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 412664. HazardyKnusperkeks added a comment. More Traits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + curdeius wrote: > curdeius wrote: > > How about other kinds? > > This doesn'

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

curdeius added a comment. More failing cases: `__alignof`, `alignof` (two different categories) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 ___ cfe-commits

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + ---

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, cjdb. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a s