[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mehdi_amini added a comment. Forgot to mention, we configure this build with: cmake -G Ninja ${src_dir}/llvm -DLLVM_TARGETS_TO_BUILD="X86;NVPTX;AMDGPU" -DLLVM_ENABLE_PROJECTS="lld;clang;mlir" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=Off -DLIBCXX_CXX_ABI=default -DLLVM_ENABLE_RUNTI

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mehdi_amini added a comment. I hit a config failure after f8c8bda965dd0f622de1ad3863b728661af6eb72 CMake Error at /var/lib/buildkite-agent/builds/buildkite-588bd64db9-mk2vq-1/mlir/mlir-core/libcxx/CMakeLists.txt:225 (messa

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek added a comment. D125597 should address the build error in compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 _

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

pcc added a comment. In D120727#3512177 , @paulkirth wrote: > Hi, we're seeing some failures in Fuchsia's Clang CI. Our runtimes build > seems to be unable to find `cxxabi.h`. > > The failing bot can be found here: > https://luci-milo.appspot.com/ui/p/f

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

paulkirth added a comment. Hi, we're seeing some failures in Fuchsia's Clang CI. Our runtimes build seems to be unable to find `cxxabi.h`. The failing bot can be found here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814278370664903633/overview Reposito

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

This revision was automatically updated to reflect the committed changes. Closed by commit rGa80e65e00ada: [libc++] Overhaul how we select the ABI library (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D120727?vs=429069&id=429209#toc Repository: rG LLVM Github Monor

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne accepted this revision as: libc++. ldionne marked an inline comment as done. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxr

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek accepted this revision. phosek added a comment. LGTM Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Spe

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 429069. ldionne marked 2 inline comments as done. ldionne added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/cma

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use.

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne marked 5 inline comments as done. ldionne added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

phosek added inline comments. Comment at: libcxx/CMakeLists.txt:250 + +set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) +set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Su

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne added inline comments. Comment at: libcxxabi/CMakeLists.txt:201 endif() +message(STATUS "Using libc++abi testing configuration: ${LIBCXXABI_TEST_CONFIG}") set(LIBCXXABI_TEST_PARAMS "" CACHE STRING mstorsjo wrote: > Unrelated to the rest of the patch? I

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 428658. ldionne marked 2 inline comments as done. ldionne added a comment. Rebase and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files:

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added a comment. I gave it a quick readthrough, but I don't think I can give a qualified review of the bulk of it... I noticed a couple minor details though. Comment at: libcxx/CMakeLists.txt:260 else() -set(LIBCXX_CXX_ABI_LIBNAME "default") +set(LIBCXX_CXX

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 428361. ldionne added a comment. Rebase to poke CI. Any interest in reviewing this @phosek @mstorsjo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/c

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 428108. ldionne added a comment. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. Try addressing CI issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.o

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 427721. ldionne added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/cmake/caches/CrossWinToARMLinux.cmake libcxx/CMakeL

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne added a comment. In D120727#3372594 , @mstorsjo wrote: > FWIW I think D116689 interacts with this > somewhat. I think D116689 is useful for > the fixes I want to do wrt libcxx

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added subscribers: phosek, mstorsjo. mstorsjo added a comment. FWIW I think D116689 interacts with this somewhat. I think D116689 is useful for the fixes I want to do wrt libcxxabi integration on Windows (but I haven'

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne updated this revision to Diff 412191. ldionne added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120727/new/ https://reviews.llvm.org/D120727 Files: clang/cmake/caches/CrossWinToARMLinux.cmake libcxx/CMake

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne created this revision. Herald added a subscriber: arichardson. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. This patch overhauls how we pick up the ABI library. Inste