[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; }); - if (It == TargetedStates.end()) + if (Start == TargetedStates.end()) return {}; hokein wr

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

aaron.ballman added a comment. In D120723#3356925 , @hokein wrote: > Fixed in 28ccf326725d0fea8648834c8acdbdfe3aa40d7a > . Thanks! I can confirm this is fixed on my end now. Reposito

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein added a comment. Fixed in 28ccf326725d0fea8648834c8acdbdfe3aa40d7a . Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; });

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein added a comment. In D120723#3356831 , @aaron.ballman wrote: > I'm seeing debug failures again on Windows after this. > > FAIL: Clang :: Syntax/lr-build-conflicts.test (14728 of 14729) > TEST 'Clang :: Syntax/lr-build-confl

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

aaron.ballman added a comment. Herald added a subscriber: alextsao1999. I'm seeing debug failures again on Windows after this. FAIL: Clang :: Syntax/lr-build-conflicts.test (14728 of 14729) TEST 'Clang :: Syntax/lr-build-conflicts.test' FAILED Scri

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG28efb1ccf5ea: [pseudo] Fix an out-of-bound error in LRTable::find. (authored by hokein). Herald added a project: All. Changed prior to commit: https://reviews.ll

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:115 TargetedStates, [&Src](LRTable::StateID S) { return S < Src; }); - if (It == TargetedStates.end(

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. The linear scan should not escape the TargetedStates range. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120723 Files: clang/lib/Tooli