[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-02 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae60884dfe16: [clang][dataflow] Add flow condition constraints to Environment (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Thanks, this looks wonderful! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev marked 2 inline comments as done. sgatev added a comment. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), ymandel wrote: > xazax.hun wrote: > > As far

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 412256. sgatev added a comment. Herald added a project: All. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), xazax.hun wrote: > As far as I understand, we need to do the double lookup (`find` and l

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:43 + + auto Res = ConjunctionVals.try_emplace( + std::move(Key), As far as I understand, we need to do the double loo

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 412162. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/Analysis/FlowSensitive/Datafl

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr Slvr) xazax.hun wrote: > ymandel wrote: > > I think `S` would be

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 412160. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/in

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr Slvr) ymandel wrote: > I think `S` would be easier to read. I

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:41 + /// + /// `Slvr` must not be null. + DataflowAnalysisContext(std::unique_ptr

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 412034. sgatev added a comment. Minor changes to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120711/new/ https://reviews.llvm.org/D120711 Files: clang/include/clang/Analysis/FlowSensitive/Dataflow

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

2022-03-01 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See