[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added a comment. In D120573#3415517 , @abidmalikwaterloo wrote: > Are you going to work on it? Just confirming. I am working on D122255 > . The code generation part for the dynamic > condition is useful.

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Are you going to work on it? Just confirming. I am working on D122255 . The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification. Corre

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); ggeorgakoudis wrote: > abidmalikwaterlo

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); abidmalik

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective &D) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); Why a

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1852 +int BestIdx = getBestVariantMatchForContext(StaticVMIs, OMPCtx); + +EmitStmt(StaticWhenClauses[BestIdx]->getDirective()); This approach is valid for static condi

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Does anyone implement/take care of the "otherwise" clause? If I am correct, OpenMP 5.2 supports otherwise instead of the default for meta directive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120573/new/ https

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis updated this revision to Diff 414139. ggeorgakoudis added a comment. Herald added subscribers: kbarton, nemanjai. Fix tentative parsing reverting Fix device codegen for metadirectives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12057

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

ggeorgakoudis created this revision. Herald added subscribers: arphaman, guansong, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG LLVM G