This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcf4a31fc0f97: [clang][deps] Remove
'-fmodules-cache-path=' arguments (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120474/new/
https://reviews.llvm.org/D120474
__
jansvoboda11 updated this revision to Diff 413387.
jansvoboda11 added a comment.
Update TODO instead of removing it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120474/new/
https://reviews.llvm.org/D120474
Files:
clang/lib/Tooling/DependencySca
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36
+ llvm::erase_if(Args, [](const std::string &Arg) {
+return Arg.find("-fmodules-cache-path=") == 0;
+ });
dexonsmith wrote:
> Is that the only
dexonsmith added inline comments.
Herald added a project: All.
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36
+ llvm::erase_if(Args, [](const std::string &Arg) {
+return Arg.find("-fmodules-cache-path=") == 0;
+ });
Is that t
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
With explicit modules build, the '-fmodules-cache-path=' argument is unused.
This patch r
