This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa6ef3635461c: [clang][deps] Disable implicit module maps
(authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D120465?vs=
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, with a suggested change for the text of the comment.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273
+ // However, some module
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273
+ // However, some module maps loaded implicitly during the dependency scan can
+ // describe anti-dependencies. That happens when the current module is marked
+
dexonsmith added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273
+ // However, some module maps loaded implicitly during the dependency scan can
+ // describe anti-dependencies. That happens when the current module is marked
+ /
