This revision was automatically updated to reflect the committed changes.
Closed by commit rGd813116c9dea: [NFC][Lexer] Remove getLangOpts function from
Lexer (authored by yurai007).
Herald added a project: All.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
yurai007 added a comment.
Rebased to https://reviews.llvm.org/D120334 and simplified by removing
non-static Lexer::getSpelling function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120404/new/
https://reviews.llvm.org/D120404
__
yurai007 updated this revision to Diff 412120.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120404/new/
https://reviews.llvm.org/D120404
Files:
clang/include/clang/Lex/Lexer.h
clang/lib/Lex/Lexer.cpp
clang/lib/Lex/ModuleMap.cpp
Index: clang
yurai007 updated this revision to Diff 410802.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120404/new/
https://reviews.llvm.org/D120404
Files:
clang/include/clang/Lex/Lexer.h
clang/lib/Lex/Lexer.cpp
clang/lib/Lex/ModuleMap.cpp
Index: clang/
serge-sans-paille accepted this revision.
serge-sans-paille added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Lex/Lexer.h:313
+ /// getSpelling - This is non-staic variant of getSpelling method which
+ /// doesn't require
yurai007 added inline comments.
Comment at: clang/lib/Lex/ModuleMap.cpp:1617
const char *Start = SpellingBuffer.data();
-unsigned Length =
-Lexer::getSpelling(LToken, Start, SourceMgr, L.getLangOpts());
+unsigned Length = L.getSpelling(LToken, Start, SourceMg
yurai007 created this revision.
yurai007 added reviewers: serge-sans-paille, cor3ntin, jansvoboda11, ymandel,
nikic, xbolva00.
yurai007 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Give that there is only one external user of Lexer::get
