RKSimon added a comment.
Relying on implicit dependencies doesn't often work very well - please can you
confirm what kind of builds you have tested this with? Which projects? shared
libs? build types?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
kadircet added a comment.
Mostly a review of the clangd changes, I am not familiar with all the other
parts (and not necessarily everyone will be) hence some explicit testing
results would be great.
Also please upload the patch with full context.
Comment at: clang-tools-extra
mehdi_amini added a comment.
Please expand the description and include how you figured this out and how do
we know it is actually correct.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120375/new/
https://reviews.llvm.org/D120375