[PATCH] D120375: Trim unnecessary component/library dependencies.

2022-02-23 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. Relying on implicit dependencies doesn't often work very well - please can you confirm what kind of builds you have tested this with? Which projects? shared libs? build types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D120375: Trim unnecessary component/library dependencies.

2022-02-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Mostly a review of the clangd changes, I am not familiar with all the other parts (and not necessarily everyone will be) hence some explicit testing results would be great. Also please upload the patch with full context. Comment at: clang-tools-extra

[PATCH] D120375: Trim unnecessary component/library dependencies.

2022-02-22 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Please expand the description and include how you figured this out and how do we know it is actually correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120375/new/ https://reviews.llvm.org/D120375