[PATCH] D120359: [clang-format][NFC] Remove redundant semi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d03548f63ad: [clang-format][NFC] Remove redundant semi (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks updated this revision to Diff 410904. HazardyKnusperkeks added a comment. Corrected diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120359/new/ https://reviews.llvm.org/D120359 Files: clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/unittests/Format

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks added a comment. In D120359#3339638 , @curdeius wrote: > I don't really understand this change. You say in the description that you > remove the semicolon, but you actually add it. > Also, it's a common pattern not to add a semicolon a

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. Oops! For some reason, I thought the patch was //removing// the semi. See also D117301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

curdeius added a comment. I don't really understand this change. You say in the description that you remove the semicolon, but you actually add it. Also, it's a common pattern not to add a semicolon and make all macro calls look like a normal statement (with a semi at the call place). I'm not op

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All "calls