Re: [PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-23 Thread Serge Guelton via cfe-commits
Sure! ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-23 Thread Dawid Jurczak via Phabricator via cfe-commits
yurai007 added a comment. Mentioned follow-up: https://reviews.llvm.org/D120404 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333 ___ cfe-commits mailing list cfe

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-23 Thread Dawid Jurczak via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbe38a784e28: [NFC][Lexer] Make access to LangOpts more consistent (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-23 Thread Dawid Jurczak via Phabricator via cfe-commits
yurai007 added a comment. Thank you all for review! In D120333#3339730 , @serge-sans-paille wrote: > I don't object to the change but it may me wonder if there would be a way to > remove the apparent redundancy in the API here? If you don't mind let m

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-23 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. I don't object to the change but it may me wonder if there would be a way to remove the apparent redundancy in the API here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333 _

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

2022-02-22 Thread Dawid Jurczak via Phabricator via cfe-commits
yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, serge-sans-paille, ymandel, jansvoboda11, cor3ntin. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change without any good reason Lexer::LangO