[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-03-07 Thread Phoebe Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4de9a752d6af: [X86] Add helper enum for ternary intrinsics (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-03-07 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/ https://reviews.llvm.org/D120307 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-03-06 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but pls wait for 1 or 2 days to see if there are any comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-03-06 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/ https://reviews.llvm.org/D120307 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-02-22 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:5944 + (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C), \ + (unsigned char)(imm), (__mmask16)-1)) + craig.topper wrote: > Why do we need to change the

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

2022-02-22 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:5944 + (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C), \ + (unsigned char)(imm), (__mmask16)-1)) + Why do we need to change the type on `imm` her