This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4de9a752d6af: [X86] Add helper enum for ternary intrinsics
(authored by pengfei).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
RKSimon accepted this revision.
RKSimon added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120307/new/
https://reviews.llvm.org/D120307
___
cfe-commits mailing list
cfe-commits@lists.llv
LuoYuanke accepted this revision.
LuoYuanke added a comment.
This revision is now accepted and ready to land.
LGTM, but pls wait for 1 or 2 days to see if there are any comments from others.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120307/new/
pengfei added a comment.
Herald added a project: All.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120307/new/
https://reviews.llvm.org/D120307
___
cfe-commits mailing list
cfe-commits@lists.llvm.
pengfei added inline comments.
Comment at: clang/lib/Headers/avx512fintrin.h:5944
+ (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C),
\
+ (unsigned char)(imm), (__mmask16)-1))
+
craig.topper wrote:
> Why do we need to change the
craig.topper added inline comments.
Comment at: clang/lib/Headers/avx512fintrin.h:5944
+ (__v16si)(__m512i)(A), (__v16si)(__m512i)(B), (__v16si)(__m512i)(C),
\
+ (unsigned char)(imm), (__mmask16)-1))
+
Why do we need to change the type on `imm` her