[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

nikic added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:107 + if (TARGET LLVMHello) +list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule) + endif() Shouldn't this be LLVMHello? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar added a comment. Herald added a project: All. @vtjnash There hasn't been consensus on removing support for standalone builds yet, and I'm in favor of keeping them as are some other distribution maintainers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

MaskRay added a comment. In D120301#3346236 , @vtjnash wrote: > Seems extra complexity, and less desirable to lose test coverage, when it > seems the option may already be unreliable and soon to be deprecated by > https://reviews.llvm.org/D119383. @Mask

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

vtjnash added a subscriber: MaskRay. vtjnash added a comment. Seems extra complexity, and less desirable to lose test coverage, when it seems the option may already be unreliable and soon to be deprecated by https://reviews.llvm.org/D119383. @MaskRay is that accurate? Repository: rG LLVM Git

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar created this revision. tstellar added a reviewer: vtjnash. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang-tools-extra. This fixes clang + clang-tools-extra standalone build after 36892727e4f19a60778e371d78f8fb09d8122c85