[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-03-14 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG806bbc49dc07: [OpenMP] Try to embed offloading objects after codegen (authored by jhuber6). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, wait for the other patches though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 ___

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-02-21 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 410405. jhuber6 added a comment. Removing unrelated changes and adding test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120270/new/ https://reviews.llvm.org/D120270 Files: clang/lib/CodeGen/CodeGenModule.

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-02-21 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D120270#3336272 , @jdoerfert wrote: > Can we have a test for this? Sure. Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts,

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Can we have a test for this? Comment at: clang/include/clang/CodeGen/BackendUtil.h:48 - void EmbedObject(llvm::Module *M, const CodeGenOptions &CGOpts, DiagnosticsEngine &Diags); Seems unrelated, please remove i

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

2022-02-21 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: ormris, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently we use the `-fembed-offload-o