[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3540780 , @aaron.ballman wrote: > In D120244#3540746 , @aaron.ballman > wrote: > >> I'll roll back the `#warning` use and report back when that's done. > > I've rolled it back

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3540746 , @aaron.ballman wrote: > I'll roll back the `#warning` use and report back when that's done. I've rolled it back in 6273b5cbcdd346a833120c55061ab56f61827068

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3540703 , @ldionne wrote: > In D120244#3540598 , @aaron.ballman > wrote: > >> The system header including a header that's explicitly deprecated is dubious >> practice, b

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3540598 , @aaron.ballman wrote: > The system header including a header that's explicitly deprecated is dubious > practice, but that does still require some amount of timing coordination. I agree, and I'll be filing b

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3540598 , @aaron.ballman wrote: > We could maybe extend `#pragma clang deprecate` to deprecate inclusion of the > current file so that it acts sort of like a `[[deprecated]]` attribute that > triggers on inclus

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3539852 , @ldionne wrote: > In D120244#3538660 , @aaron.ballman > wrote: > >> In D120244#3538380 , @ldionne >> wrote: >> >>> We

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3538660 , @aaron.ballman wrote: > In D120244#3538380 , @ldionne wrote: > >> We've started having several internal user complaints because their system >> headers are suddenly

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3538380 , @ldionne wrote: > We've started having several internal user complaints because their system > headers are suddenly triggering a warning for using ``. This seems > to be caused by the fact that `#warni

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. We've started having several internal user complaints because their system headers are suddenly triggering a warning for using ``. This seems to be caused by the fact that `#warning` is surfaced to users even when the `#warning` is present in a system header (which make

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5ccd6680198: [clang][sema] Enable first-class bool support for C2x (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https:/

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Headers/stdbool.c:2 +// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c11 -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C11 %s +// R

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 414005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 3 inline comments as done. tbaeder added a comment. In D120244#3368216 , @aaron.ballman wrote: > Precommit CI is failing: > > Failed Tests (1): > > Clang :: Headers/stdbool.c Heh, I guess I need to make a habit of running the tests also

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Precommit CI is failing: Failed Tests (1): Clang :: Headers/stdbool.c Comment at: clang/lib/Headers/stdbool.h:18 +#warning \ +"the header is deprecated in C2x. bool, t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Headers/stdbool.h:16 /* Don't define bool, true, and false in C++, except as a GNU extension. */ #ifndef __cplusplus #define bool _Bool aaron.ballman wrote: > We're

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3362215 , @tbaeder wrote: > Thanks for the links to the papers. What's the best way of updating > https://clang.llvm.org/c_status.html#c2x with the new papers? I update that page from the WG14 editor's report (o

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113 - Implemented `WG14 N2674 The noreturn attribute `_. - Implemented `WG14 N2418 Adding the u8 character prefix

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413279. tbaeder marked 3 inline comments as done. tbaeder added a comment. Thanks for the links to the papers. What's the best way of updating https://clang.llvm.org/c_status.html#c2x with the new papers? I added the changes to `stdbool.h`, but I haven't bee

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Herald added a project: All. Thanks for working on this! It's worth noting that http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2935.pdf was what was adopted by WG14 a few weeks ago, so you should be checking against that one, not the initial version of the paper

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/test/Sema/c2x-bool.c:10 +_Static_assert(_Generic(true, bool : true, default: false)); +_Static_assert(_Generic(false, bool : true, default: false)); + Not that clang-format wanted me to format these two lines, but

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements N2393. I am a bit confused by the proposal only taking about adding "true" and "fal