alexfh closed this revision.
alexfh added a comment.
Committed revision 245042.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia updated this revision to Diff 32146.
angelgarcia added a comment.
Add comments.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index: unittests/clang-t
klimek added inline comments.
Comment at: clang-tidy/IncludeSorter.cpp:144
@@ -138,3 +143,3 @@
IncludeKinds NonEmptyKind = IK_InvalidInclude;
- for (int i = IncludeKind - 1; i >= 0; --i) {
+ for (int i = IK_InvalidInclude - 1; i >= 0; --i) {
if (!IncludeBucket[i].empty()
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! Looks good with a comment.
Comment at: clang-tidy/IncludeSorter.cpp:118
@@ +117,3 @@
+ if (SourceLocations.empty()) {
+// If there are no includes
angelgarcia updated this revision to Diff 32143.
angelgarcia added a comment.
Update tests.
http://reviews.llvm.org/D12017
Files:
clang-tidy/IncludeInserter.cpp
clang-tidy/IncludeSorter.cpp
clang-tidy/IncludeSorter.h
unittests/clang-tidy/IncludeInserterTest.cpp
Index: unittests/clang-t
klimek added a comment.
Please add a regression test.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
If there weren't any includes in the file, or all of them
