[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. Fix looks good. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. In D120159#3415112 , @kda wrote: > This appears to have broken buildbot: sanitizer-x86_64-linux-fast > > Validating if reversion clears it up. > > Then will revert. Fixed by 8f66f1371981bda1af1ca43d505e1bc5836b3e36

[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. This appears to have broken buildbot: sanitizer-x86_64-linux-fast Validating if reversion clears it up. Then will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___

[PATCH] D120159: [Clang] Implement __builtin_source_location.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd61487490022: [Clang] Implement __builtin_source_location. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D120159?vs=41

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159

[PATCH] D120159: [Clang] Implement __builtin_source_location.

erichkeane accepted this revision. erichkeane added a comment. no comments, looks fine to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___ cfe-c

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. Ping; any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 412087. jyknight marked an inline comment as done. jyknight added a comment. Fix and test __impl lookup within the definition of std::source_location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D120159#3349271 , @jyknight wrote: > In D120159#3349069 , @aaron.ballman > wrote: > >> Ah, okay, that's a good point. I was thinking t

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight marked 8 inline comments as done. jyknight added a comment. In D120159#3349069 , @aaron.ballman wrote: > Ah, okay, that's a good point. I was thinking this would show up in the AST > in places like: > > template > auto func() -> Ty; > >

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. In D120159#3348927 , @jyknight wrote: > In D120159#3341224 , @aaron.ballman > wrote: > >> Btw, I think there may be some functionality missing for AST dumping, so I'd >> like to se

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. In D120159#3341224 , @aaron.ballman wrote: > Btw, I think there may be some functionality missing for AST dumping, so I'd > like to see some additional tests for that. I'm not sure what test would actually show a problem (or l

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 411811. jyknight marked 15 inline comments as done. jyknight added a comment. Update per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 Files: cl

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 411692. jyknight added a comment. Minor tweaks to comments and docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 Files: clang/docs/LanguageExtensions.rst cla

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. Ah, one more thing I missed -- you should add a release note for this functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. Thank you for this! I've got some initial comments on it. Btw, I think there may be some functionality missing for AST dumping, so I'd like to see some additional tests for that. Comment at: clang/docs/LanguageExtensions.rst:3343-3344 +defined,

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight created this revision. jyknight added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, arphaman, martong. Herald added a reviewer: shafik. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This builtin