[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0f6cfb7b9f: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

vvereschaka added a comment. @phosek @rovka no need those changes for `CrossWinToARMLinux.cmake`. `TARGET_TRIPLE` is using to parametrize the cache file only. But if there is a goal to completely remove `TARGET_TRIPLE` from the source tree I will update the cache file and the buildbot configura

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 413141. phosek added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.site.cfg.

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Amir accepted this revision. Amir added a comment. LGTM from BOLT side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list cfe-commits@

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

ldionne added a comment. Herald added a project: All. Shall we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commits mailing list cfe-commi

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

rovka accepted this revision. rovka added a comment. I'm happy if the buildbots are happy :D thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-com

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek added a comment. Provide fallback for `TARGET_TRIPLE` and print a warning about deprecation and future removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 409394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.sit

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

ldionne accepted this revision. ldionne added a comment. LGTM from libc++/libc++abi's perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 ___ cfe-commi

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

rovka added a comment. Is this going to break for everyone that still passes TARGET_TRIPLE to cmake? If so, we should probably have a period where we support both. In particular, this might break some of our buildbots

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D1199

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek created this revision. phosek added reviewers: beanz, smeenai, ldionne, compnerd. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, ar