[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0604d86c07ab: Darwin: introduce a global override for debug prefix map entries. (authored by aprantl). Herald added a project: clang. Changed prior

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added a comment. In D119850#3326266 , @thakis wrote: > (I wish there was a flag that said "clang, never ever read any env vars > please". Some people think that builds should be deterministic and not depend > on random env vars people might have

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

thakis added a comment. (I wish there was a flag that said "clang, never ever read any env vars please". Some people think that builds should be deterministic and not depend on random env vars people might have set (and then not do correct incremental rebuilds when the value of such env var fla

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) arphaman wrote: > Suggestion: It might be good to factor out

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl updated this revision to Diff 408944. aprantl added a comment. Refactored code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119850/new/ https://reviews.llvm.org/D119850 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:686 +return; + if (!StringRef(GlobalRemapEntry).contains('=')) +D.Diag(diag::err_drv_invalid_argument_to_option) Suggestion: It might be good to factor out the code that ve

[PATCH] D119850: Darwin: introduce a global override for debug prefix map entries

aprantl created this revision. aprantl added reviewers: dexonsmith, arphaman. aprantl requested review of this revision. This patch adds a new Darwin clang driver environment variable in the spirit of RC_DEBUG_OPTIONS, called RC_DEBUG_PREFIX_MAP, which allows a meta build tool to add one additio