This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5a74e6a21c95: [Modules] Add module structure output to
-module-file-info. (authored by iains).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
iains updated this revision to Diff 410599.
iains added a comment.
reformat.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119823/new/
https://reviews.llvm.org/D119823
Files:
clang/lib/Frontend/FrontendActions.cpp
clang/test/Modules/cxx20-modu
iains added a comment.
this now uses the split-file approach to the test case so that we have the test
case self-contained, but avoid the use of preprocessor directives before the
module lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119823/
iains updated this revision to Diff 410568.
iains added a comment.
rebased, amended testcases to use split-file, handle partition enumerations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119823/new/
https://reviews.llvm.org/D119823
Files:
cla
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
urnathan wrote:
> iains wrote:
> > urnathan wrote:
> > > urnathan w
urnathan added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
iains wrote:
> urnathan wrote:
> > urnathan wrote:
> > > ChuanqiXu wrote:
> > > > iains wrote:
> > > > > ChuanqiXu wrote:
> > > > > > According to [[
>
iains added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
urnathan wrote:
> urnathan wrote:
> > ChuanqiXu wrote:
> > > iains wrote:
> > > > ChuanqiXu wrote:
> > > > > According to [[
> > > > > http://www.open-std.
urnathan added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
urnathan wrote:
> ChuanqiXu wrote:
> > iains wrote:
> > > ChuanqiXu wrote:
> > > > According to [[
> > > > http://www.open-std.org/jtc1/sc22/wg21/docs/p
urnathan added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
ChuanqiXu wrote:
> iains wrote:
> > ChuanqiXu wrote:
> > > According to [[
> > > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html |
ChuanqiXu added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
iains wrote:
> ChuanqiXu wrote:
> > According to [[
> > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html |
> > P1857R3 ]], it migh
iains added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
ChuanqiXu wrote:
> According to [[
> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html |
> P1857R3 ]], it might not be good to add macr
ChuanqiXu added inline comments.
Comment at: clang/test/Modules/module-file-info-cxx20.cpp:26
+
+#if TU == 1
+
According to [[
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html | P1857R3
]], it might not be good to add macro declarative befor
iains updated this revision to Diff 408930.
iains added a comment.
address review comment, fix formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119823/new/
https://reviews.llvm.org/D119823
Files:
clang/lib/Frontend/FrontendActions.cpp
urnathan added inline comments.
Comment at: clang/lib/Frontend/FrontendActions.cpp:817-824
+#if 0
+ case Module::ModuleHeaderUnit:
+return "Header Unit";
+ case Module::ModulePartitionInterface:
+return "Partition Interface";
+ case Module::ModulePartitionImplementatio
iains created this revision.
iains added reviewers: dblaikie, aprantl, urnathan, ChuanqiXu.
iains published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It is useful to be able to visualise the C++20 modules content of a PCM file
both for inspect
15 matches
Mail list logo
