[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e3235f604d: [libTooling] Change Tranformer's consumer to take multiple changes (authored by li.zhe.hua, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408847. li.zhe.hua added a comment. Remove old constructor Not sure how to resolve the ambiguous constructor issue on MSVC. This is probably SFINAE-able, but not sure how to repro locally to iterate. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408699. li.zhe.hua added a comment. Attempt fix for Windows compilation issue Work around ambiguous function call by foregoing the delgating constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119745/

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua added a comment. In D119745#3320154 , @ymandel wrote: > Looks good. But, please add tests. Thanks! Done; added a test for a multi-AtomicChange edit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408636. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119745/new/ https://reviews.llvm.org/D119745 Files: clang/include/cl

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408587. li.zhe.hua added a comment. Update based on comments. Update test to switch off depreated constructor. Fix assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119745/new/ https://reviews.llvm.org/

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Looks good. But, please add tests. Thanks! Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:27 + using ChangesConsumer = std::function> Changes)>; -

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. li.zhe.hua requested review of this revision. Herald added a project: clang. Previously, Transformer would invoke the consumer once per file modified per match, in addition to any errors encountered. The consumer is not aware