[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added a comment. Thanks for reporting this (also reported here: https://github.com/llvm/llvm-project/issues/54426). I have a fix up for review here: D122237 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

sberg added subscribers: rnk, sberg. sberg added a comment. Herald added a project: All. I started to experience Clang crashing when building Firebird (as part of building LibreOffice) in clang-cl mode on Windows, and I think it is due to this change in combination with D2733

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17c9fcd6f6fc: [clang][lex] Use `ConstSearchDirIterator` in lookup cache (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } jansvoboda11 wrote: > ahoppen wrote: > > I haven’t looked into this in total details but `

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 updated this revision to Diff 408733. jansvoboda11 added a comment. Use `std::next` and `ConstSearchDirIterator::Idx`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119721/new/ https://reviews.llvm.org/D119721 Files: clang/include/c

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } ahoppen wrote: > I haven’t looked into this in total details but `&*` looks a little awkwa

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

ahoppen added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:710 + CacheLookup.HitIt = HitIt; + noteLookupUsage(&*HitIt - &*search_dir_begin(), Loc); } I haven’t looked into this in total details but `&*` looks a little awkward to me. Dereference

[PATCH] D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache

jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch starts using the new iterator type in `ConstSearchDirIterator`. Depen