[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa081a0654f35: [clang][lex] NFC: De-duplicate some #include_next logic (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119716/new/

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:2207 + const FileEntry *&LookupFromFile) const; + /// Install the standard preprocessor pragmas: ahoppen wrote: > I there a reason why this uses an

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

2022-02-15 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 408730. jansvoboda11 added a comment. Return `std::pair` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119716/new/ https://reviews.llvm.org/D119716 Files: clang/include/clang/Lex/Preprocessor.h clang/

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

2022-02-14 Thread Alex Hoppen via Phabricator via cfe-commits
ahoppen added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:2207 + const FileEntry *&LookupFromFile) const; + /// Install the standard preprocessor pragmas: I there a reason why this uses an out parameter instead

[PATCH] D119716: [clang][lex] NFC: De-duplicate some #include_next logic

2022-02-14 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: ahoppen, Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a FIXME and de-duplicates some `#include_next` logic Depend