[PATCH] D119711: Add asan support for MSVC debug runtimes

2023-06-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added subscribers: thieta, mstorsjo. rnk added a comment. + @mstorsjo @thieta Since we were talking about the complexity involved in choosing the correct ASan runtime, there is actually even more involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D119711: Add asan support for MSVC debug runtimes

2023-06-04 Thread Dan via Phabricator via cfe-commits
DanWillans added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Hi all, Has there been any progress on this? I want to run clang-tidy on some code being compiled in debug with MSVC but I hit the clang-diagnostic-error note 'D.Diag(clang::diag::note_drv_address_sanit

[PATCH] D119711: Add asan support for MSVC debug runtimes

2022-02-15 Thread Petr Mikhalitsyn via Phabricator via cfe-commits
lo1ol added a comment. Ok, I get current situation. Sorry for my late answer. I made some investigation yesterday and compared msvc and clang versions of asan. In my tests msvc version seems more stable. All my tests is written via catch2 framework (v2.13.8). So, first example is: #define CA

[PATCH] D119711: Add asan support for MSVC debug runtimes

2022-02-14 Thread Curtis J Bezault via Phabricator via cfe-commits
cbezault added a comment. Imo I agree that this shouldn’t be merged until the debug variants of the asan runtime are getting built publicly. @stevewishnousky Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119711/new/ https://reviews.llvm.org/D11971

[PATCH] D119711: Add asan support for MSVC debug runtimes

2022-02-14 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added subscribers: cbezault, vitalybuka. rnk added a comment. I'm hesitant to do this. The main reason we disabled the use of the debug runtimes was that the debug runtimes interfered with malloc interception, which leads to crashes and a generally poor user experience. I'd like some confir

[PATCH] D119711: Add asan support for MSVC debug runtimes

2022-02-14 Thread Petr Mikhalitsyn via Phabricator via cfe-commits
lo1ol created this revision. lo1ol added a reviewer: rnk. lo1ol requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use special debug asan versions (prefixed with asan_dbg) for MSVC debug runtimes (/MTd, /MDd, /LDd). Resolves: https://github