[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

2022-02-13 Thread sstwcw via Phabricator via cfe-commits
sstwcw abandoned this revision. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16854 + // that things still get aligned. + Alignment.ColumnLimit = 20; EXPECT_EQ("inta(int x,\n" HazardyKnusperkeks wrote: > I disagree. Li

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

2022-02-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/WhitespaceManager.cpp:578 } -unsigned Cha

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

2022-02-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. This isolates the problem that changes the unit test mentioned in https://reviews.llvm.org/D119599. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119625/new/ https://reviews.llvm.org/D119625 ___

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

2022-02-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119625 Files