[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-13 Thread sstwcw via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24b3db45c7d: [clang-format] Add option to align compound assignments like `+=` (authored by sstwcw). Changed prior to commit: https://reviews.llv

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-13 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. You either get commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access or ask someone of us to push it for you. In the latter case we need a name and mail for the commit. I recommend the former, especially if you want to contribute m

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. How to get this revision committed? I thought it would happen automatically now that it is accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 _

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-12 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. @MyDeveloperDay Will you please accept this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list cfe-c

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-10 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 414347. sstwcw added a comment. Modify initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-10 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. LGTM. Thanks a lot! Comment at: clang/lib/Format/Format.cpp:1181-1184 + LLVMStyle.AlignConsecutiveAssignments = { + /*Enabled=*/false, /*AcrossEmptyLines=*/false, + /*AcrossComments=*/false, /*AlignCompound=*

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-09 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-09 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. Any more problems with this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413313. sstwcw added a comment. remove `int` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/c

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-06 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16800 + Alignment)); +} + sstwcw wrote: > HazardyKnusperkeks wrote: > > Can you test it with `AlignConsecutiveDeclarations`? > Do you mean like the forma

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-06 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. About chained assignments, the current program does not attempt to align them in a consistent way. And this revision doesn't change it. Both before and after this revision, the output depend on the order of the statements. Foo = Bar = 5; Int Baz = 5; Int Baz

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. How does this handle cases with multiple assignments in one statement, and can tests be added to demonstrate the behaviour. Foo += Bar <<= 5; Int Baz = 5; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ htt

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16800 + Alignment)); +} + HazardyKnusperkeks wrote: > Can you test it with `AlignConsecutiveDeclarations`? Do you mean like

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413271. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Only some small things, I think we are nearly done and this is a great change. Comment at: clang/include/clang/Format/Format.h:139-140 + /// + /// They can also be read as a whole for compatibility. The choices + /// are: + /// - None ---

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413251. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type, field_name = re.match(r'([<>:\w

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 7 inline comments as done. sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type, fi

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413152. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/dump_

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-04 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413149. sstwcw marked 2 inline comments as done. sstwcw added a comment. Herald added a project: All. Take out things in other revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 18 inline comments as done. sstwcw added a comment. The YAML stuff are now in D120363 . Comment at: clang/docs/ClangFormatStyleOptions.rst:1408-1415 + Precise control over the wrapping of braces. + + .. code-block:: c++ + +#

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D119599#3336936 , @curdeius wrote: > Nice job! Please let us a bit of time to review that. > Also, I think it would be good to get a reviewer that knows well the yaml > parts. Or even split it to a separate revision

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:406 + + Options for aligning stuff. Stuff? Comment at: clang/docs/ClangFormatStyleOptions.rst:482-483 + + * ``bool AlignCompound`` Only for ``AlignConsecutiv

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:121 def __str__(self): -return '\n'.join(map(str, self.values)) +return self.comment + '\n' + '\n'.join(map(str, self.values)) Can this change be separate? why is

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added subscribers: njames93, grimar. MyDeveloperDay added a comment. Does the YAML changes need unit tests in (llvm/unittests/Support) ? also we should pull in a reviewer from llvm/Support (maybe @njames93, @grimar ) who have made YAML specific changes in this header. Repositor

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Could you mark the comments as done (if they are done) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing l

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-21 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Nice job! Please let us a bit of time to review that. Also, I think it would be good to get a reviewer that knows well the yaml parts. Or even split it to a separate revision. And this part needs tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-21 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 410400. sstwcw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/dump_

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-21 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 3 inline comments as done. sstwcw added a comment. About the unit tests that failed in B150668 . It looks like they were stopped because they took over 1 minute. I ran the first test on my laptop. Both this revision and main took about 2 minute

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-02-21 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 410271. sstwcw retitled this revision from "Add option to align compound assignments like `+=`" to "[clang-format] Add option to align compound assignments like `+=`". sstwcw added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a p