[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3319955 , @aaron.ballman wrote: > LGTM, thank you for the additional test coverage! Do you need me to commit on > your behalf? If so, what name and email address would you like me to use for > patch attribution? Tha

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

This revision was automatically updated to reflect the committed changes. Closed by commit rGeffd6dd63a65: [Clang][Sema] Add a missing regression test about Wliteral-range (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/ne

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the additional test coverage! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? Re

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3318913 , @aaron.ballman wrote: > In D119528#3316311 , @junaire wrote: > >>> I think we should probably have test coverage for `long double` as well, >>> but I also wonder whe

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408407. junaire added a comment. Add triple info to avoid tests failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman added a comment. In D119528#3316311 , @junaire wrote: >> I think we should probably have test coverage for `long double` as well, but >> I also wonder whether it makes sense to add coverage for the small >> floating-point types (like `_Flo

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408134. junaire added a comment. Add missing blank. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: clang/test/

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408133. junaire added a comment. long double should use `L` as literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. > I think we should probably have test coverage for `long double` as well, but > I also wonder whether it makes sense to add coverage for the small > floating-point types (like `_Float16`) as well, or whether we already have > coverage for those elsewhere. Test long do

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire updated this revision to Diff 408129. junaire added a comment. Add tests for long double. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119528/new/ https://reviews.llvm.org/D119528 Files: clang/test/Sema/warn-literal-range.c Index: cla

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-literal-range.c:25 + +double d5 = 0x0.42p+4200; // expected-warning {{magnitude of floating-point constant too large for type 'double'; maximum is 1.7976931348623157E+308}} I think we should p

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire created this revision. junaire added a reviewer: aaron.ballman. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a missing test, covering the different kinds of floating-point literals, like hexadecimal floats