[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGf8cedc642d9b: [clang] Never wrap a nullptr in CXXNewExpr::getArraySize() (authored by tbaeder). Repository

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an arr

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 410233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/S

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array tbaeder wrote: >

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array aaron.ballman wrote: >

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. Continues to LGTM, though I had a recommendation for the release note. Feel free to land when you'd like. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` +

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 409173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/S

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. In D119525#3317623 , @tbaeder wrote: > In D119525#3314383 , @aaron.ballman > wrote: > >> Can you also add a release note for the change? > > Would this go in the "libclang" section

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added a comment. In D119525#3314383 , @aaron.ballman wrote: > Can you also add a release note for the change? Would this go in the "libclang" section in `clang/docs/ReleaseNotes.rst`? Or somewhere else?

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); aaron.ballman

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407912. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Can you also add a release note for the change? Comment at: clang/include/clang/AST/ExprCXX.h:2271 + +if (auto Result = +

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); I changed this just for clarity, not doing it did not ca

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407885. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. In D119525#3313554 , @tbaeder wrote: > This is a pretty big gotcha at best and I feel like `getArraySize()` should > return `None` in that case instead... thoughts? I think it is a gotcha -- some places protect against a n

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407785. tbaeder added a comment. This is a pretty big gotcha at best and I feel like `getArraySize()` should return `None` in that case instead... thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the crash from https://github.com/llvm/llvm-project/issues/53742 `CXXNewExpr::getArraySize()`