[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. In D119477#3397311 , @aaron.ballman wrote: > I've commit on your behalf in 403d7d8d7093d6637a006f8b3f75382294259d3f > , and > I'm going to add a release

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 403d7d8d7093d6637a006f8b3f75382294259d3f , and I'm going to add a release note in a separate commit as I missed that feedback dur

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.org/D119477 ___

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr updated this revision to Diff 416695. kimgr added a comment. Address review feedback - Restore accidentally removed test line - Clarify diagnostic expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.or

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a()); } // expected-error {{'alloc::A::ret_a' is not a constant expression}} expected-error {{'alloc::to_lvalue_ref' is not a constant expression}} + // exp

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. The changes here generally look good, and I'm happy to see that more of our test cases are diagnosing similar to other compilers with the changes. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a()); }

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. @aaron.ballman Friendly Monday ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.org/D119477 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. Herald added a project: All. Gentle weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.org/D119477 ___ cfe-commits mailing list cfe-commits@

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. I have a local branch with both D119476 and this patch. - Rebased on latest main (853ca5472314e109b98e46f0985f27f79e17d2bd ) - Ran `ninja check-clang` and `ninja tools/

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. I haven't had the chance to review this yet (in C standards meetings again this week), but I did notice that https://reviews.llvm.org/D119095 seems to be touching on a related (or possibly the same) issue. Can you coordinate with the other patch author to make sur

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a subscriber: aaron.ballman. kimgr added a comment. @aaron.ballman This patch replaces https://reviews.llvm.org/D117391 as a potential solution for https://github.com/llvm/llvm-project/issues/53044. I can't swear that the new diagnostics in cxx2a-consteval.cpp are standards-conformi

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr created this revision. kimgr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Full-expressions are Sema-generated implicit nodes that cover constant-expressions and expressions-with-cleanup for temporaries. Ignore those as part of imp