bkramer added a comment.
Can you try setting up the virtual files with the vfs::InMemoryFileSystem
stuff? There are some examples how to set up with OverlayFileSystem in tree.
InMemoryFileSystem was written with windows path separators in mind, I just
never tried to run it on windows :)
http:
klimek added a reviewer: bkramer.
klimek added a comment.
+Benjamin to share another yak :D
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Aug 13, 2015 at 10:50 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added a comment.
>
> I would think most Windows users would be surprised if we showed them
> paths with /s instead of \s, but I'm fine with us using / internally if it
> doesn't leak out t
alexr added a subscriber: alexr.
alexr added a comment.
Just to remind everybody, different OSes handle Unicode differently as well.
Think of it as case insensitivity for the different Unicode ways of encoding
the same glyph. For example U+00DC (LATIN CAPITAL LETTER U WITH DIAERESIS) vs
U+0055
rsmith added a comment.
I would think most Windows users would be surprised if we showed them paths
with /s instead of \s, but I'm fine with us using / internally if it doesn't
leak out to the user.
klimek: if we want to nativize, I think the right thing to do is to remove the
wrong "normaliza
yaron.keren added a comment.
I think she wishes your second option.
Note that windows API actually do accept slash as seperator and need no
conversion.
https://en.wikipedia.org/wiki/Path_(computing)#MS-DOS.2FMicrosoft_Windows_style
The issues are with apps that interpret slash as switch, ma
klimek added a comment.
In http://reviews.llvm.org/D11944#223597, @chapuni wrote:
> I wish, in clang/llvm, internal path separator would be slash.
> It'd be better to use backslash where it'd be really required, for example
> interface to cmd.exe or MS toolchain.
>
> For me, native-ization is n
chapuni added a comment.
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is nightmare.
http://reviews.llvm.org/D11944
__
yaron.keren added inline comments.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString<1024> NativeFilename;
+ llvm::sys::path::native(Filename, NativeFilename);
+
rsmith wrote:
> I have two concerns with this:
>
> 1) It's needless
klimek added a comment.
In http://reviews.llvm.org/D11944#222975, @rsmith wrote:
> In principle, normalizing slashes on Windows makes sense here. But we
> shouldn't use `llvm::sys::path::native`, because it's just too broken.
Ok, so if I understand you correctly it would make sense to create a
rsmith added a comment.
In principle, normalizing slashes on Windows makes sense here. But we shouldn't
use `llvm::sys::path::native`, because it's just too broken.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString<1024> NativeFilename;
+ llvm:
klimek added a comment.
The case sensitivity stuff is related, but a much larger problem - while the
native paths are system dependent, the case sensitivity is file system
dependent - I can have case insensitive file systems on any OS.
http://reviews.llvm.org/D11944
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is also the case insensitivity issue, see
https://llvm.org/bugs/show_bug.cgi?id=17993
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm
klimek created this revision.
klimek added reviewers: rsmith, chapuni.
klimek added a subscriber: cfe-commits.
For virtual files to work correctly on Windows, we need to canonicalize
the paths before looking into the caches.
This is basically a request for comments - if we want to go this route,
14 matches
Mail list logo
