[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. It's nothing to do with your patch, and you don't need to worry about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364 ___ cfe-comm

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-12 Thread Shivam Rajput via Phabricator via cfe-commits
phyBrackets added a comment. Hey @rjmccall , would you tell me about this build fail https://green.lab.llvm.org/green/job/lldb-cmake/41339/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364 ___

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-12 Thread Shivam Rajput via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGde4e855204aa: Refactor nested if else with ternary operator in CGExprScalar.cpp (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1193

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-11 Thread Shivam Rajput via Phabricator via cfe-commits
phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Hey Thanks, would you please help to land this patch . I don't have commit access . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-11 Thread Shivam Rajput via Phabricator via cfe-commits
phyBrackets added a comment. In D119364#3310170 , @rjmccall wrote: > Sure, LGTM Yeah, will keep in mind. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364

[PATCH] D119364: Refactor nested if else with ternary operator in CGExprScalar.cpp

2022-02-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119364/new/ https://reviews.llvm.org/D119364 _