This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc5ea8e913893: Use-after-dtor detection for trivial base
classes. (authored by eugenis, committed by vitalybuka).
Repository:
rG LLVM Github Monore
vitalybuka updated this revision to Diff 416040.
vitalybuka added a comment.
addressing some @kda comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119300/new/
https://reviews.llvm.org/D119300
Files:
clang/lib/CodeGen/CGClass.cpp
clang/te
kda accepted this revision.
kda added inline comments.
Comment at: compiler-rt/test/msan/dtor-base-access.cpp:24
+class TrivialBaseAfter {
+public:
+ int tb1;
nit: add single space (consistent indent).
Comment at: compiler-rt/test/msan/dtor-ba
kda added inline comments.
Comment at: clang/lib/CodeGen/CGClass.cpp:1872
// Ignore trivial destructors.
+ if (BaseClassDecl->hasTrivialDestructor()) {
vitalybuka wrote:
> kda wrote:
> > Maybe not "Ignore"?
> @kda I assume it's about inconsistent co
vitalybuka accepted this revision.
vitalybuka added a comment.
Herald added a project: All.
@eugenis I will prepare google3 and land it?
Comment at: clang/lib/CodeGen/CGClass.cpp:1872
// Ignore trivial destructors.
+ if (BaseClassDecl->hasTrivialDestructor()) {
--
kda added inline comments.
Comment at: clang/lib/CodeGen/CGClass.cpp:1872
// Ignore trivial destructors.
+ if (BaseClassDecl->hasTrivialDestructor()) {
Maybe not "Ignore"?
Comment at: clang/lib/CodeGen/CGClass.cpp:1907
// I
eugenis updated this revision to Diff 408071.
eugenis added a comment.
Fix handling of empty base classes and suppress tail calls.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119300/new/
https://reviews.llvm.org/D119300
Files:
clang/lib/CodeGe
eugenis created this revision.
eugenis added reviewers: kda, vitalybuka.
eugenis requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald added a subscriber: Sanitizers.
-fsanitize-memory-use-after-dtor detects memory access after a
subobject is destroyed but its memory
