chh added a comment.
If there were only two different types,
we should have mangled name 'd' for double and 'e' for long double,
even if their implementations are the same.
The problem came when g++ has __float80 and __float128 types,
and long double could be implemented as __float80 or __float12
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244541: Add NaCl to long double/fp128 mangling test
(authored by dschuff).
Changed prior to commit:
http://reviews.llvm.org/D11922?vs=31744&id=31747#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
dschuff added a comment.
Looks like all the other unix targets that use IEEEDouble as their format do
this too, including all the NaCl compilers.
http://reviews.llvm.org/D11922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rnk added a comment.
In http://reviews.llvm.org/D11922#221185, @dschuff wrote:
> I'm not an expert in mangling, and I'm not 100% sure if this is right. The
> Itanium ABI's spec lists "long double" as the same as __float80. Should we
> use "double" in mangling instead?
If you can have differen
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Feel free to commit more test coverage like this with just post-commit review.
http://reviews.llvm.org/D11922
___
cfe-commits mailing list
cfe-co
dschuff added a comment.
I'm not an expert in mangling, and I'm not 100% sure if this is right. The
Itanium ABI's spec lists "long double" as the same as __float80. Should we use
"double" in mangling instead?
http://reviews.llvm.org/D11922
___
cfe
dschuff created this revision.
dschuff added reviewers: rnk, chh.
dschuff added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
NaCl is a platform where long double is the same as double.
Its mangling is spelled with "long double" but its ABI lowering is the same
as double.
htt
