[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kadircet added a comment. sent out https://reviews.llvm.org/D135245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kadircet added a comment. yeah sorry for the mess here. i agree that we should move StandardLibrary to its own library. i'll try to take a stab at this tomorrow, if no one does it before then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/n

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

ilya-biryukov added a comment. In D119130#3829816 , @thakis wrote: > This makes clang-format depend on clang's AST library Oops, definitely an unintended outcome. Ping @kadircet, in case he missed this. He should know best who can fix this. Repository:

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

thakis added a comment. Or, alternatively, maybe Recognizer could stay in clangd (or move to a separate lib); looks like that's the only thing in StandardLibrary.h that needs `clang/AST/Decl.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

thakis added a comment. Herald added a project: All. This makes clang-format depend on clang's AST library, which it shouldn't. Could this move into a dedicated library, or in some library that Format doesn't depend on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

paulwalker-arm added a comment. Yep, that did the trick. Many Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307333 , @paulwalker-arm wrote: > After this commit I am seeing the link time error > > ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() > const > >>> referenced by StandardLibrary.cpp:11

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

paulwalker-arm added a comment. After this commit I am seeing the link time error ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() const >>> referenced by StandardLibrary.cpp:118 (/home/pmw/projects/upstream-llvm/llvm-project/clang/lib/Tooling/Inclusions/StandardLibra

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46a6f5ae148a: [clangd] NFC: Move stdlib headers handling to Clang (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D11913

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307222 , @sammccall wrote: > In D119130#3304505 , @kbobyrev > wrote: > >> Oh, and also regarding the Python generator scripts: they don't seem to work >> with the latest arc

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 407093. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add a test for C Standard Library symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/StandardLibraryTest.cpp:50 + EXPECT_THAT(Vector->headers(), ElementsAre(*VectorH)); +} + maybe add a test for

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

sammccall added a comment. In D119130#3304505 , @kbobyrev wrote: > Oh, and also regarding the Python generator scripts: they don't seem to work > with the latest archives :( 2018 mentioned in the docs (works perfectly) but > 2019 crashes. Yikes, we sho

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406827. kbobyrev added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra/

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. Oh, and also regarding the Python generator scripts: they don't seem to work with the latest archives :( 2018 mentioned in the docs (works perfectly) but 2019 crashes. Probably not very relevant if we switch to libc++ eventually. Repository: rG LLVM Github Monorepo

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406800. kbobyrev added a comment. Fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra