[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson abandoned this revision. probinson added a comment. In D119040#3363406 , @kadircet wrote: > Thanks for the change, but the test is actually checking for rename in > presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the > p

[PATCH] D119040: Fix LookupTest where it was missing an assertion

kadircet added a comment. Thanks for the change, but the test is actually checking for rename in presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the proper fix here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a reviewer: hokein. probinson added a subscriber: hokein. probinson added a comment. Herald added a project: All. + @hokein who has done work in the one place where `replaceNestedName` is used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.ll

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a subscriber: bkramer. probinson added a comment. Ping; + @bkramer who reviewed the original patch that added this test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040 ___ cfe-commit

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a reviewer: kadircet. probinson added a subscriber: kadircet. probinson added a comment. Ping; +@kadircet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119040/new/ https://reviews.llvm.org/D119040 ___ cfe-commits mailing list

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a comment. By "the EXPECT_EQ was never executed" I mean, replacing it with `assert(false);` does not crash the test. The string `"a::b::Foo"` was never seen by the Visitor. Maybe this indicates some much more subtle, deeper problem; I don't know. This change does cause the EX

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson created this revision. probinson added a reviewer: ioeric. probinson requested review of this revision. The preceding EXPECT_EQ was never executed; modifying the test input made that happen. Found by the Rotten Green Tests project. https://reviews.llvm.org/D119040 Files: clang/unit