[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe993b20c049d: [flang][driver] Add support for `-emit-llvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://revie

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. A believe that all of Kiran's comments have been addressed and pre-merge CI is also passing now (that was one of the concerns). Kiran has not accepted this yet, but he will be away for a few weeks. I will merge this as is to unblock further work. I more than happy to

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 409401. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td flang/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407139. awarzynski added a comment. Remove the change from `fir::CodeGenSpecifics::get` (this was uploaded as a seperate patch: https://reviews.llvm.org/D119332) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407130. awarzynski added a comment. Herald added a subscriber: mehdi_amini. Updated `fir::CodeGenSpecifics::get` to see whether the unit tests pass on Windows. If they do, I'll create a seperate patch with this change. Repository: rG LLVM Github Monore

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407070. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td flang/in

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406832. awarzynski added a comment. Disable the LIT test on Windows, simplify how output is dumped in `EmitLLVMAction::ExecuteAction`, remove `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. I believe that Windows failures are due to the missing support here: https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf473825ae8a/flang/lib/Optimizer/CodeGen/Target.cpp#L290. I can disable the LIT test on Windows, but I'm not sure how to do it fo

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

kiranchandramohan added a comment. The tests added are failing in the windows CI. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto &defKinds = ci.invocation().semanticsContext().de

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks! I just have a minor nit, feel free to ignore it. Comment at: flang/lib/Frontend/FrontendActions.cpp:471 + + if (!ci.IsOutputStreamNull()) { +llvmModule->prin

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406428. awarzynski added a comment. Remove the calls to `setTargetTriple` and `setKindMapping`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/incl

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406425. awarzynski marked 2 inline comments as done. awarzynski added a comment. Update comments + add an `assert` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto &defKinds = ci.invocation().semanticsContext().defaultKinds(); rovka wrote: > Nit:

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

rovka added inline comments. Comment at: flang/include/flang/Frontend/FrontendOptions.h:37 + /// Emit a .llvm file + EmitLLVM, Shouldn't this be .ll? Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. This has been extracted from `fir-dev`. Original PR: https://github.com/flang-compiler/f18-llvm-project/pull/1113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 _

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406380. awarzynski added a comment. Rebase, remove trailing "_" from member variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/c

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a project: Flang. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoe